Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver, backend: configure mmap size based on quota #7525

Merged
merged 2 commits into from
Mar 23, 2017

Conversation

heyitsanthony
Copy link
Contributor

Mechanism for permitting mmaps > 10GB.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, after go import fixes

@heyitsanthony heyitsanthony force-pushed the big-backend branch 2 times, most recently from ee92272 to 7468669 Compare March 17, 2017 17:31
@codecov-io
Copy link

Codecov Report

Merging #7525 into master will increase coverage by <.01%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##           master    #7525      +/-   ##
==========================================
+ Coverage   70.23%   70.23%   +<.01%     
==========================================
  Files         320      320              
  Lines       26205    26223      +18     
==========================================
+ Hits        18405    18419      +14     
- Misses       6343     6352       +9     
+ Partials     1457     1452       -5
Impacted Files Coverage Δ
etcdserver/server.go 79.39% <100%> (+0.26%)
etcdctl/ctlv3/command/migrate_command.go 63.78% <100%> (ø)
etcdserver/quota.go 71.42% <33.33%> (+1.66%)
mvcc/backend/backend.go 75.72% <95.45%> (+1.97%)
pkg/adt/interval_tree.go 80.4% <0%> (-6.42%)
etcdserver/api/v3rpc/maintenance.go 76.25% <0%> (-2.5%)
etcdserver/cluster_util.go 73.42% <0%> (-1.4%)
etcdserver/api/v3rpc/watch.go 88.48% <0%> (-1.05%)
clientv3/lease.go 91.11% <0%> (ø)
proxy/grpcproxy/adapter/watch_client_adapter.go 94.11% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5015480...8a3fee1. Read the comment docs.

plog.Warningf("backend quota %v exceeds maximum quota %v; using maximum", s.Cfg.QuotaBackendBytes, backend.MaxQuotaBytes)
return &backendQuota{s, backend.MaxQuotaBytes}
if s.Cfg.QuotaBackendBytes > MaxQuotaBytes {
plog.Warningf("backend quota %v exceeds maximum recommended quota %v", s.Cfg.QuotaBackendBytes, MaxQuotaBytes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we change the behavior here to allow user to use more than 8gb?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@xiang90
Copy link
Contributor

xiang90 commented Mar 22, 2017

LGTM

@fanminshi
Copy link
Member

lgtm

@heyitsanthony heyitsanthony merged commit 7ef75e3 into etcd-io:master Mar 23, 2017
@heyitsanthony heyitsanthony deleted the big-backend branch March 23, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants